Merge lp:~joetalbott/core-image-tester/fix_names into lp:core-image-tester

Proposed by Joe Talbott
Status: Merged
Merged at revision: 37
Proposed branch: lp:~joetalbott/core-image-tester/fix_names
Merge into: lp:core-image-tester
Diff against target: 38 lines (+5/-2)
1 file modified
core_image_tester/worker.py (+5/-2)
To merge this branch: bzr merge lp:~joetalbott/core-image-tester/fix_names
Reviewer Review Type Date Requested Status
Francis Ginther Approve
Review via email: mp+262634@code.launchpad.net

Commit message

Add release to container name and metadata file whitelist.

Description of the change

Add release to container name and metadata file whitelist.

To post a comment you must log in.
Revision history for this message
Francis Ginther (fginther) wrote :

Looks good.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'core_image_tester/worker.py'
--- core_image_tester/worker.py 2015-05-08 05:05:23 +0000
+++ core_image_tester/worker.py 2015-06-22 21:38:34 +0000
@@ -58,6 +58,7 @@
58 image_name = body['image_name']58 image_name = body['image_name']
59 device = body['device']59 device = body['device']
60 channel = body['channel']60 channel = body['channel']
61 release = body['release']
61 except KeyError as e:62 except KeyError as e:
62 logger.error("Message does not contain required ", extra=extra)63 logger.error("Message does not contain required ", extra=extra)
63 return MessageActions.Retry64 return MessageActions.Retry
@@ -98,7 +99,8 @@
98 extra=extra99 extra=extra
99 )100 )
100101
101 container_name = "core-{}-{}-{}".format(102 container_name = "core-{}-{}-{}-{}".format(
103 release,
102 channel,104 channel,
103 device,105 device,
104 image_name,106 image_name,
@@ -139,7 +141,7 @@
139141
140142
141def _create_run_metadata_file(directory, request):143def _create_run_metadata_file(directory, request):
142 """Create a metadata file in 'directory' with some of the data from 'request'144 """Create a metadata file in 'directory' with some data from 'request'
143145
144 We want to make sure that, as (potentially confidential) items are added to146 We want to make sure that, as (potentially confidential) items are added to
145 the request that we don't blindly add them to the metadata file, so we147 the request that we don't blindly add them to the metadata file, so we
@@ -147,6 +149,7 @@
147149
148 """150 """
149 key_whitelist = [151 key_whitelist = [
152 'release',
150 'channel',153 'channel',
151 'device',154 'device',
152 'test_branch',155 'test_branch',

Subscribers

People subscribed via source and target branches