Canonical Click Reviewers tools (obsolete)

Merge lp:~joetalbott/click-reviewers-tools/add_deps into lp:click-reviewers-tools

  1. add_deps
  2. Merge into trunk
Proposed by Joe Talbott
Status: Needs review
Proposed branch: lp:~joetalbott/click-reviewers-tools/add_deps
Merge into: lp:click-reviewers-tools
Diff against target: 24 lines (+15/-0)
1 file modified
README (+15/-0)
To merge this branch: bzr merge lp:~joetalbott/click-reviewers-tools/add_deps
Reviewer Review Type Date Requested Status
Jamie Strandboge (community) Needs Fixing
Review via email: mp+293327@code.launchpad.net

Commit message

Add note about test dependencies to README.

Description of the change

Add note about test dependencies to README.

To post a comment you must log in.
Revision history for this message
Jamie Strandboge (jdstrand) wrote :

This is fine to add to the README but the complete list is actually in debian/control:
Build-Depends: debhelper (>= 9~),
               pep8,
               pyflakes3,
               python3-all (>= 3.2~),
               python3-apt,
               python3-debian,
               python3-lxml,
               python3-magic,
               python3-setuptools,
               python3-simplejson,
               python3-xdg,
               python3-yaml,
               squashfs-tools

Reply
Revision history for this message
Jamie Strandboge (jdstrand) :
review: Needs Fixing
Reply
lp:~joetalbott/click-reviewers-tools/add_deps updated
640. By Joe Talbott <email address hidden>

Use complete list of dependencies and move up in README.

* Moved up since dependencies are also needed before running
  tests locally.

Unmerged revisions

640. By Joe Talbott <email address hidden>

Use complete list of dependencies and move up in README.

* Moved up since dependencies are also needed before running
  tests locally.

639. By Joe Talbott <email address hidden>

Add test dependencies to README.

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'README'
2--- README 2016-02-10 20:00:25 +0000
3+++ README 2016-04-29 20:50:33 +0000
4@@ -20,6 +20,21 @@
5 This gives an alternate view on bin/click-run-checks:
6 - bin/click-review
7
8+Install dependencies: See debian/control for the latest list.
9+# Note: python >3.2 is required
10+$ sudo apt install pep8 \
11+ pyflakes3 \
12+ python3-all \
13+ python3-apt \
14+ python3-debian \
15+ python3-lxml \
16+ python3-magic \
17+ python3-setuptools \
18+ python3-simplejson \
19+ python3-xdg \
20+ python3-yaml \
21+ squashfs-tools
22+
23 Running tests locally:
24 $ PYTHONPATH=$PWD ./bin/click-review /path/to/click
25

Subscribers

People subscribed via source and target branches