Merge lp:~joetalbott/adt-result-checker/make_results_public_on_failure into lp:adt-result-checker

Proposed by Joe Talbott
Status: Merged
Approved by: Joe Talbott
Approved revision: 11
Merged at revision: 11
Proposed branch: lp:~joetalbott/adt-result-checker/make_results_public_on_failure
Merge into: lp:adt-result-checker
Diff against target: 30 lines (+9/-0)
2 files modified
README.rst (+4/-0)
adt_result_checker/__init__.py (+5/-0)
To merge this branch: bzr merge lp:~joetalbott/adt-result-checker/make_results_public_on_failure
Reviewer Review Type Date Requested Status
Celso Providelo (community) Approve
Review via email: mp+253697@code.launchpad.net

Commit message

Make results public when a message is placed in the deadletter queue.

* This allows jenkins to not have to wait to timeout.

Description of the change

Make results public when a message is placed in the deadletter queue.

* This allows jenkins to not have to wait to timeout.

To post a comment you must log in.
Revision history for this message
Celso Providelo (cprov) wrote :

Josepth,

Thanks for working on this, we have done a good session of local tests together and as mentioned in the card, when result-checker has done everything it can to make the request pass but failed, releasing jenkins slaves is the best approach.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'README.rst'
--- README.rst 2015-03-19 23:26:47 +0000
+++ README.rst 2015-03-20 16:19:11 +0000
@@ -16,6 +16,10 @@
16Install the Service16Install the Service
17========================17========================
1818
19Install required packages::
20
21 $ sudo apt-get install python3-dev
22
19Build and activate a virtualenv with python3::23Build and activate a virtualenv with python3::
2024
21 $ virtualenv -p python3 --system-site-packages ve25 $ virtualenv -p python3 --system-site-packages ve
2226
=== modified file 'adt_result_checker/__init__.py'
--- adt_result_checker/__init__.py 2015-03-20 02:23:17 +0000
+++ adt_result_checker/__init__.py 2015-03-20 16:19:11 +0000
@@ -127,6 +127,11 @@
127 queue.put(message.payload)127 queue.put(message.payload)
128 queue.close()128 queue.close()
129129
130 # make the results public so jenkins doesn't have to timeout.
131 request_id = message.payload['request_id']
132 if result_tarball_exists_in_swift(request_id):
133 self.post_results(request_id)
134
130 def maybe_retry_message(self, message, reason=''):135 def maybe_retry_message(self, message, reason=''):
131 """Re-queue this message for retrial, unless it's retry limit has been136 """Re-queue this message for retrial, unless it's retry limit has been
132 reached, in whch case insert it into the dead letter queue.137 reached, in whch case insert it into the dead letter queue.

Subscribers

People subscribed via source and target branches