Merge lp:~joetalbott/adt-cloud-worker/add_log_rotation into lp:adt-cloud-worker

[Joe Talbott]

Add log rotation and flake8 checking. Fix flake8 issues as well.

Add log rotation and flake8 checking. Fix flake8 issues as well.

[Celso Providelo (cprov)]

review: Approve

=== modified file 'adt_cloud_worker/__init__.py'
--- adt_cloud_worker/__init__.py	2015-03-24 01:55:25 +0000
+++ adt_cloud_worker/__init__.py	2015-04-14 22:36:38 +0000
@@ -138,7 +138,8 @@
 
 
 def _create_run_metadata_file(directory, request):
-    """Create a metadata file in 'directory' with some of the data from 'request'
+    """Create a metadata file in 'directory' with some of the data from
+    'request'.
 
     We want to make sure that, as (potentially confidential) items are added to
     the request that we don't blindly add them to the metadata file, so we
@@ -273,7 +274,11 @@
         os.path.join(__file__, '../../logs/adt-cloud-worker.log'))
     log_dir = os.path.dirname(log_path)
     if os.path.exists(log_dir):
-        handler = logging.FileHandler(log_path)
+        handler = logging.handlers.TimedRotatingFileHandler(
+            log_path,
+            when='D',
+            interval=1
+        )
     else:
         print("'logs' directory '{}' does not exist, using stderr "
               "for app log.".format(log_dir))
 
=== modified file 'adt_cloud_worker/tests/test_cloud_worker.py'
--- adt_cloud_worker/tests/test_cloud_worker.py	2015-03-19 03:08:53 +0000
+++ adt_cloud_worker/tests/test_cloud_worker.py	2015-04-14 22:36:38 +0000
@@ -147,7 +147,8 @@
 class TarballCreationTests(testtools.TestCase):
 
     def create_tarball_with_cleanup(self, directory_to_tar, tarball_root):
-        tarball_path = _create_tarball_from_directory(directory_to_tar, tarball_root)
+        tarball_path = _create_tarball_from_directory(directory_to_tar,
+                                                      tarball_root)
         self.addCleanup(os.remove, tarball_path)
         return tarball_path
 
 
=== modified file 'called-by-tarmac.py'
--- called-by-tarmac.py	2015-03-17 15:07:36 +0000
+++ called-by-tarmac.py	2015-04-14 22:36:38 +0000
@@ -89,6 +89,11 @@
                 'setup.py',
                 'test',
             ],
+            [
+                os.path.join(ve_dir, 'bin', 'python3'),
+                'setup.py',
+                'flake8',
+            ],
         )
         for cmd in all_cmds:
             ret = _run_command(cmd)
 
=== modified file 'setup.py'
--- setup.py	2015-03-04 04:21:56 +0000
+++ setup.py	2015-04-14 22:36:38 +0000
@@ -21,13 +21,12 @@
 import sys
 assert sys.version_info >= (3,), 'Python 3 is required'
 
-from setuptools import find_packages, setup, Extension
+from setuptools import find_packages, setup
 
 
 VERSION = '1.0.0'
 
 
-
 setup(
     name='adt-cloud-worker',
     version=VERSION,
 
=== modified file 'test_requirements.txt'
--- test_requirements.txt	2015-03-04 21:44:54 +0000
+++ test_requirements.txt	2015-04-14 22:36:38 +0000
@@ -1,3 +1,4 @@
 testtools
 fixtures
+flake8==2.4.0