Code review comment for lp:~joerlend.schinstad-deactivatedaccount/quidgets/main

Revision history for this message
Jo-Erlend Schinstad (joerlend.schinstad-deactivatedaccount) wrote :

Well. I had introduced a bug that caused most of the errors, but it was really easily fixed. But I would like to further clean up that code. I see no reason why _initialize_renderer should have its own function just for a few lines of code. But that isn't important. It works.

There was one other issue, and it wasn't really introduced by me, but just uncovered. There is a very weird if-clause in CouchGrid init that does absolutely nothing. When I fixed the if clause to do what it _has to_ be intended to do, then one of the tests fails.

I've had a look at it, and it seems that when you add a dictionary to the CouchGrid, then two empty columns are added to the store between the values from the dicts and the final desktopcouch dict. I believe this is what's causing it, but I don't know how to fix it yet and I need to understand it better.

So in essence, it's safe to merge my branch.

« Back to merge proposal