Code review comment for lp:~joergberroth/unav/format_fixes_PoiListpage

Revision history for this message
Nekhelesh Ramananthan (nik90) wrote :

> So, as long as nothing is added, trailling is fine ;-) and if something
> will be added it has to be reevaluated still.
> m Sonntag, 3. April 2016 12:14:39 CEST schrieb Nekhelesh Ramananthan
> <email address hidden>:
> > Review: Needs Fixing
> >
> > Well for starters it should be SlotsLayout.Trailing (with one
> > L). And secondly according to the documentation,
> > SlotsLayout.Last ensures that the icon doesn't move and is
> > always the last item on the listitem. While SlotsLayout.Trailing
> > allows the icon to just be on the trailing slot and move if more
> > elements are added.
> >
> > In trunk, the icon *appears* to move because of the variable
> > width that I set..not because of the slots positioning.
>

Just curious, but what do you have against using SlotsLayouts.Last? By using it, we can ensure the icon is always the last position regardless of any code changes in the future. We do want the icon to be always the last position, no?
>
>
> --
> Versandt, mit Dekko von meinem Ubuntu-Gerät

« Back to merge proposal