Code review comment for lp:~joel-pythonica/phatch/pep8

Revision history for this message
Stani (stani) wrote :

Great! For Phatch source code we use LF (\n not \r\n) as line endings otherwise I can't make it run when the file is executable:

$ ./run_pep8_test.py
bash: ./run_pep8_test.py: /usr/bin/python^M: bad interpreter: No such file or directory

I have fixed this now for you, but please change your editor to use LF line endings in the future.

I've updated the blueprint with tasks:
- convert the "...".split() commands to lists to make them more dynamic
- exclude linux tests on windows (-e linux) for nose
- do not exclude windows tests on windows (-e windows) for nose
- let it report the files which are not yet converted to PEP8, if possible with percentage

Please update the blueprint as you progress: put DONE after each subtask as you progress.
Before you continue make sure to merge from trunk first:
bzr merge lp:phatch

As I merged in the new pep8.py many new pep8 errors are reported which need fixing. I am working on them, but feel free to help. I'd like to have the trunk as soon as possible again to be pep8 clean.

Thanks for your work!

review: Needs Fixing

« Back to merge proposal