Code review comment for lp:~joe.julian/bzr/bdist_rpm

Revision history for this message
John A Meinel (jameinel) wrote :

The diff doesn't look quite right, as it includes a bunch of things other than just MANIFEST.in and README_BDIST_RPM. And the other things look like changes that Andrew and myself had done...

Anyway, I'm sure the MANIFEST.in needs at least a *.txt, since we use bzrlib/help_topics/en/* as part of the runtime system (eg, bzr help authentication).

Using:
  bzr ls -R bzrlib/ | sed 's/.*\(\..*\)/\1/' | grep -v '/' | sort -u

We have these extensions:
.c
.crt
.csr
.h
.key
.patch
.pxd
.py
.pyc
.pyd
.pyx
.txt

Assuming we don't care about the test suite, the .crt and .csr aren't needed (we also have a few files without extensions used by the test suite). Same for .patch .key. Certainly .pyc isn't needed, and we wouldn't want to bundle .pyd (or .so). So I think the line should be:
recursive-include bzrlib *.py *.pyx *.pxd *.txt *.c *.h

review: Needs Fixing

« Back to merge proposal