Checkbox Provider - Resource

Code review comment for ~jocave/plainbox-provider-resource:net-if-mgmt-master-mode

  1. Git
  2. lp:~jocave/plainbox-provider-resource
  3. net-if-mgmt-master-mode
  4. Merge into master
Revision history for this message
Kristin Chuang (kristinchuang) wrote :

+1
Along with https://code.launchpad.net/~jocave/plainbox-provider-checkbox/+git/plainbox-provider-checkbox/+merge/400446, the current logic works in the following trial runs:

* UC16 enablement project, wifi-AP & network-manager pre-installed
[Expected] wifi-ap jobs run (its pass/fail status unrelated to this MR), nmcli jobs skipped
[Actual] OK, see https://pastebin.canonical.com/p/GHVhyYxQJC/

* rpi 2b, stock rpi armhf UC20, network-manager manually installed
[Expected] wifi-ap jobs skipped, nmcli jobs run (its pass/fail status unrelated to this MR)
[Actual] OK, see https://pastebin.canonical.com/p/jkTc6KQw8c/

review: Approve

« Back to merge proposal