Code review comment for ~jocave/plainbox-provider-resource:use-distro-if-available

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Using distro module will imply having to deal with this bug: https://github.com/nir0s/distro/issues/260

There's a patch in checkbox-core-snap:

https://git.launchpad.net/checkbox-core-snap/commit/snap/snapcraft.yaml?id=57f5af0255ac19c8c447ebd01be756138c6e4d37

Not sure if we will face it on deb checkbox but it could be a good idea to catch subprocess.CalledProcessError in the resource code and fallback to the old code.

review: Needs Fixing

« Back to merge proposal