Merge ~jocave/plainbox-provider-checkbox:add-audio-loopback-manifest into plainbox-provider-checkbox:master

Proposed by Jonathan Cave
Status: Merged
Approved by: Jonathan Cave
Approved revision: 7bf0d7b3fab491ebd2e93246e7d496b1c2c5527a
Merged at revision: 2674dbb54da6335b0a7aca1d55f4b04e3b27e6e8
Proposed branch: ~jocave/plainbox-provider-checkbox:add-audio-loopback-manifest
Merge into: plainbox-provider-checkbox:master
Diff against target: 27 lines (+8/-0)
2 files modified
units/audio/jobs.pxu (+2/-0)
units/audio/manifest.pxu (+6/-0)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+374529@code.launchpad.net

Description of the change

Add an audio loopback connector manifest entry and requirement for it on alsa-loopback-automated. This allows us to keep clean test run output where peripherals are required.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
diff --git a/units/audio/jobs.pxu b/units/audio/jobs.pxu
index 0745e5c..126209e 100644
--- a/units/audio/jobs.pxu
+++ b/units/audio/jobs.pxu
@@ -679,6 +679,8 @@ flags: also-after-suspend
679command: alsa_test loopback -d 5679command: alsa_test loopback -d 5
680category_id: com.canonical.plainbox::audio680category_id: com.canonical.plainbox::audio
681estimated_duration: 5681estimated_duration: 5
682imports: from com.canonical.plainbox import manifest
683requires: manifest.has_audio_loopback_connector == 'True'
682684
683id: audio/alsa-loopback685id: audio/alsa-loopback
684_summary: Captured sound matches played one686_summary: Captured sound matches played one
diff --git a/units/audio/manifest.pxu b/units/audio/manifest.pxu
index 95417f6..d3e285b 100644
--- a/units/audio/manifest.pxu
+++ b/units/audio/manifest.pxu
@@ -13,3 +13,9 @@ unit: manifest entry
13id: has_audio_capture13id: has_audio_capture
14_name: Audio capture14_name: Audio capture
15value-type: bool15value-type: bool
16
17unit: manifest entry
18id: has_audio_loopback_connector
19prompt: Does this device have the following?:
20_name: Audio Loopback Connector
21value-type: bool

Subscribers

People subscribed via source and target branches