Merge ~jocave/plainbox-provider-checkbox:add-audio-loopback-manifest into plainbox-provider-checkbox:master

Proposed by Jonathan Cave
Status: Merged
Approved by: Jonathan Cave
Approved revision: 7bf0d7b3fab491ebd2e93246e7d496b1c2c5527a
Merged at revision: 2674dbb54da6335b0a7aca1d55f4b04e3b27e6e8
Proposed branch: ~jocave/plainbox-provider-checkbox:add-audio-loopback-manifest
Merge into: plainbox-provider-checkbox:master
Diff against target: 27 lines (+8/-0)
2 files modified
units/audio/jobs.pxu (+2/-0)
units/audio/manifest.pxu (+6/-0)
Reviewer Review Type Date Requested Status
Sylvain Pineau (community) Approve
Review via email: mp+374529@code.launchpad.net

Description of the change

Add an audio loopback connector manifest entry and requirement for it on alsa-loopback-automated. This allows us to keep clean test run output where peripherals are required.

To post a comment you must log in.
Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

+1

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/units/audio/jobs.pxu b/units/audio/jobs.pxu
2index 0745e5c..126209e 100644
3--- a/units/audio/jobs.pxu
4+++ b/units/audio/jobs.pxu
5@@ -679,6 +679,8 @@ flags: also-after-suspend
6 command: alsa_test loopback -d 5
7 category_id: com.canonical.plainbox::audio
8 estimated_duration: 5
9+imports: from com.canonical.plainbox import manifest
10+requires: manifest.has_audio_loopback_connector == 'True'
11
12 id: audio/alsa-loopback
13 _summary: Captured sound matches played one
14diff --git a/units/audio/manifest.pxu b/units/audio/manifest.pxu
15index 95417f6..d3e285b 100644
16--- a/units/audio/manifest.pxu
17+++ b/units/audio/manifest.pxu
18@@ -13,3 +13,9 @@ unit: manifest entry
19 id: has_audio_capture
20 _name: Audio capture
21 value-type: bool
22+
23+unit: manifest entry
24+id: has_audio_loopback_connector
25+prompt: Does this device have the following?:
26+_name: Audio Loopback Connector
27+value-type: bool

Subscribers

People subscribed via source and target branches