Code review comment for ~jocave/plainbox-provider-checkbox:remove-base64-and-archiving-in-jobs

Revision history for this message
Pierre Equoy (pieq) wrote :

I think we don't need to remove the compression part, especially since some logs can get *really* big.

For example, I think firmware/fwts_desktop_diagnosis_results_hwe.log.gz should remain a log.gz and that its command should just go from

[ -f $PLAINBOX_SESSION_SHARE/fwts_desktop_diagnosis_results_hwe.log ] && gzip -c $PLAINBOX_SESSION_SHARE/fwts_desktop_diagnosis_results_hwe.log | base64

to

[ -f $PLAINBOX_SESSION_SHARE/fwts_desktop_diagnosis_results_hwe.log ] && gzip -c $PLAINBOX_SESSION_SHARE/fwts_desktop_diagnosis_results_hwe.log

review: Needs Fixing

« Back to merge proposal