Code review comment for ~jocave/plainbox-provider-checkbox:move-wireless-jobs-to-newer-templated-version

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

One thing I didin't notice is that using the also-after-suspend flag adds a dependency on suspend/suspend_advanced_auto which is not desirable on client cert test plan where we run just suspend/suspend_avdanced (manual). I'd then create a second version of the after suspend nested part for manual QA test plans to avoid bringing an unexpected dep. Don't forget to also add the also-after-suspend-manual flag to job definitions.

We can still land this MR, I'll propose the fix to add support for manual nested part.

« Back to merge proposal