Code review comment for ~jocave/plainbox-provider-checkbox:move-wireless-jobs-to-newer-templated-version

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

1. Previous job definitions were running commands as root, are we able to run the python wrapper as the normal user now?
2. Lots of new jobs are using the environ filed which is not needed when running command as a non root user (See http://plainbox.readthedocs.io/en/latest/manpages/plainbox-job-units.html). You can delete those lines.
3. What happens if $NET_DRIVER_INFO is not set? should we condition the call to bin/net_driver_info only if the variable exists?
4. Can all _manual connection tests benefit from the python tool? to get rid again of the inline bash commands?

review: Needs Information

« Back to merge proposal