Code review comment for ~jocave/netplan/+git/netplan:dont-rebind-mwifiex
Revision history for this message
| Martin Pitt (pitti) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
0e1f616
(Get the code!)
I'm fine with applying this patch, but note that mac80211_hwsim is a bit special: it genuinely doesn't even advertise rebinding, but it's also just being used for testing so it doesn't matter much.
OTOH mwifiex_pcie actually controls real hardware, and with that "netplan apply" would stop working for renames. Obviously you do call netplan apply (otherwise you wouldn't run into the crash), so I figure you do want it to actually apply.
Can you please file a bug against the kernel with the logs and traces so that this gets fixed properly eventually?
I also have an inline comment, see below.