Merge lp:~jocave/checkbox/icon-with-internal-transparency into lp:checkbox
Proposed by
Jonathan Cave
Status: | Merged |
---|---|
Approved by: | Zygmunt Krynicki |
Approved revision: | 3851 |
Merged at revision: | 3874 |
Proposed branch: | lp:~jocave/checkbox/icon-with-internal-transparency |
Merge into: | lp:checkbox |
Diff against target: |
26 lines (+8/-3) 1 file modified
checkbox-touch/checkbox-touch.svg (+8/-3) |
To merge this branch: | bzr merge lp:~jocave/checkbox/icon-with-internal-transparency |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Zygmunt Krynicki (community) | Approve | ||
Review via email: mp+263636@code.launchpad.net |
This proposal supersedes a proposal from 2015-06-25.
Description of the change
I found it odd the way the icon appears to change due to an internal shape being transparent e.g. click on the icon in the dash and the way it appears on the splash screen
To post a comment you must log in.
I'm +1 on the change but -1 on the execution.
I realize this is a gray area (image data) but the commit lacks proper naming "checkbox-touch: $summary" and also touches other parts (as can be seen in the diff). Please either commit those separately (quick tip: run git gui, click on "amend" in the bottom of the UI, unstage everything (right-click on the file and click unstage on the left) then stage separate commits for the transparency and for the docname change, most likely ignoring everything else.