Merge lp:~jocave/checkbox/icon-with-internal-transparency into lp:checkbox

Proposed by Jonathan Cave
Status: Merged
Approved by: Zygmunt Krynicki
Approved revision: 3851
Merged at revision: 3874
Proposed branch: lp:~jocave/checkbox/icon-with-internal-transparency
Merge into: lp:checkbox
Diff against target: 26 lines (+8/-3)
1 file modified
checkbox-touch/checkbox-touch.svg (+8/-3)
To merge this branch: bzr merge lp:~jocave/checkbox/icon-with-internal-transparency
Reviewer Review Type Date Requested Status
Zygmunt Krynicki (community) Approve
Review via email: mp+263636@code.launchpad.net

This proposal supersedes a proposal from 2015-06-25.

Description of the change

I found it odd the way the icon appears to change due to an internal shape being transparent e.g. click on the icon in the dash and the way it appears on the splash screen

To post a comment you must log in.
Revision history for this message
Zygmunt Krynicki (zyga) wrote : Posted in a previous version of this proposal

I'm +1 on the change but -1 on the execution.

I realize this is a gray area (image data) but the commit lacks proper naming "checkbox-touch: $summary" and also touches other parts (as can be seen in the diff). Please either commit those separately (quick tip: run git gui, click on "amend" in the bottom of the UI, unstage everything (right-click on the file and click unstage on the left) then stage separate commits for the transparency and for the docname change, most likely ignoring everything else.

review: Needs Fixing
Revision history for this message
Zygmunt Krynicki (zyga) wrote :

+1, thanks

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1=== modified file 'checkbox-touch/checkbox-touch.svg'
2--- checkbox-touch/checkbox-touch.svg 2014-08-12 16:52:25 +0000
3+++ checkbox-touch/checkbox-touch.svg 2015-07-02 11:04:25 +0000
4@@ -18,8 +18,8 @@
5 viewBox="70.866 70.866 141.732 141.732"
6 enable-background="new 70.866 70.866 141.732 141.732"
7 xml:space="preserve"
8- inkscape:version="0.48.4 r9939"
9- sodipodi:docname="canonical-driver-test-suite.svg"><metadata
10+ inkscape:version="0.91 r13725"
11+ sodipodi:docname="checkbox-touch.svg"><metadata
12 id="metadata9"><rdf:RDF><cc:Work
13 rdf:about=""><dc:format>image/svg+xml</dc:format><dc:type
14 rdf:resource="http://purl.org/dc/dcmitype/StillImage" /></cc:Work></rdf:RDF></metadata><defs
15@@ -81,4 +81,9 @@
16 style="fill:#ffffff;fill-opacity:1;stroke:#fff9f9;stroke-width:0.08255709;stroke-opacity:1"
17 d="m 138.21665,150.88763 c 0.82891,0.14553 1.67699,-0.0746 2.37466,-0.61642 0.37173,-0.28871 0.39064,-0.31905 4.66246,-7.48717 4.67737,-7.84853 7.16128,-12.21269 7.4709,-13.12595 0.5323,-1.57009 0.27722,-2.70664 -0.84277,-3.75496 -0.4824,-0.45153 -2.07062,-1.4663 -2.22726,-1.42306 -0.0516,0.0145 -2.50543,4.07691 -5.4528,9.02818 -2.94744,4.95122 -5.36827,8.99671 -5.37963,8.98999 -0.0115,-0.007 -0.66502,-1.02644 -1.45253,-2.26599 -0.78749,-1.23955 -1.52919,-2.36671 -1.64822,-2.50483 -0.29784,-0.34563 -1.21376,-0.79785 -1.71919,-0.84874 -0.63652,-0.0641 -1.3545,0.13288 -1.92803,0.529 -0.43747,0.3022 -0.55898,0.43389 -0.85844,0.93039 -0.30971,0.51316 -0.35526,0.64796 -0.40628,1.19649 -0.10082,1.08441 -0.0604,1.165 3.05293,6.09098 l 2.81103,4.44763 0.58015,0.37356 c 0.41041,0.26433 0.69215,0.39329 0.9631,0.44087 l 0,0 z"
18 id="path4542"
19- inkscape:connector-curvature="0" /></svg>
20+ inkscape:connector-curvature="0" /><path
21+ style="fill:#ffffff"
22+ d="m 61.317104,106.59928 c 0,-5.6011 -0.190589,-7.508956 -0.750699,-7.514721 -0.412884,-0.0042 -2.101957,-0.648562 -3.753496,-1.431806 l -3.002796,-1.424076 -5.254106,5.171993 -5.254105,5.172 -4.806368,-4.77818 -4.806368,-4.778179 5.086449,-5.117745 5.086449,-5.117744 -1.597312,-4.053775 -1.597313,-4.053775 -7.391667,0 -7.391667,0 0,-6.888489 0,-6.888489 7.538828,-0.168083 7.538827,-0.168083 1.461858,-3.599215 1.461858,-3.599215 -5.233884,-5.258247 -5.233884,-5.258246 4.778178,-4.806368 4.778178,-4.806367 5.263548,5.239161 5.263548,5.239161 1.956154,-0.788315 c 1.075886,-0.433573 2.834473,-1.079405 3.907972,-1.435183 l 1.951818,-0.646868 0,-7.706509 0,-7.706508 3.6734,0 c 3.516375,0 3.657921,0.05776 3.311277,1.351258 -0.199168,0.743193 -0.365814,7.094107 -0.370324,14.113144 -0.0073,11.405258 -0.112516,12.761885 -0.989502,12.761885 -4.048297,0 -9.547309,3.751279 -11.759387,8.021939 -1.671143,3.226327 -1.776375,9.352968 -0.212933,12.397077 2.289276,4.457347 6.285603,7.399051 11.096833,8.168398 l 2.457348,0.392945 0,13.736105 0,13.73611 -3.603356,0 -3.603356,0 0,-7.50699 z"
23+ id="path3396"
24+ inkscape:connector-curvature="0"
25+ transform="translate(70.865997,70.865997)" /></svg>
26\ No newline at end of file

Subscribers

People subscribed via source and target branches