Code review comment for lp:~jocave/checkbox/icon-with-internal-transparency

Revision history for this message
Zygmunt Krynicki (zyga) wrote :

I'm +1 on the change but -1 on the execution.

I realize this is a gray area (image data) but the commit lacks proper naming "checkbox-touch: $summary" and also touches other parts (as can be seen in the diff). Please either commit those separately (quick tip: run git gui, click on "amend" in the bottom of the UI, unstage everything (right-click on the file and click unstage on the left) then stage separate commits for the transparency and for the docname change, most likely ignoring everything else.

review: Needs Fixing

« Back to merge proposal