Code review comment for ~jocave/checkbox-ng:modify-bootstrap-output

Revision history for this message
Sylvain Pineau (sylvain-pineau) wrote :

Since you're not using the estimated_time in the new version, let's completely remove those lines in _run_bootstrap_jobs():

        estimated_time = 0
        for job_id in jobs_to_run:
            job = self.sa.get_job(job_id)
            if (job.estimated_duration is not None and
                    estimated_time is not None):
                estimated_time += job.estimated_duration
            else:
                estimated_time = None

[...]

            if (job.estimated_duration is not None and
                    estimated_time is not None):
                estimated_time -= job.estimated_duration

review: Needs Fixing

« Back to merge proposal