Code review comment for lp:~jobh/dolfin/fast-array

On 6 March 2012 17:55, Garth Wells <email address hidden> wrote:

> On 6 March 2012 15:13, Joachim Haga <email address hidden> wrote:
> > After looking at la_get_set_items.i: _get_vector_values(), shown below, I
> > think I'll punt on this. It's just too much work for an uncertain outcome
> > (it is quite possible that a lot of complexity has to be added back to
> deal
> > with cases like this, making this pointless).
> >
> > // Returns the values from a Vector.
> > dolfin::Array<double>& _get_vector_values( dolfin::GenericVector* self)
>
> We should just be able to use std::vector in the C++ interface for this.
>

Hm, yes, I guess an extra copy won't matter that much here. I'll see how it
goes.

-j.