Code review comment for lp:~jobh/dolfin/fast-array

Revision history for this message
Joachim Haga (jobh) wrote :

>
> > I'm happy in principle, but want some clarity on Array. Can we make it
> > that Array is always a view (i.e., never owns that data), and
> > therefore cannot be resized? This would clean up some const hacks.
>
> I agree. For all argments needing to be resized should use
> std::vector. Not sure where the resize functionality is/was used.

It is possible (of course). There are quite a few user-exposed interfaces
that need changing (f.x. all the GeneralVector::set/get methods, since it
would be strange to just change the get methods).

And it may be a lot of grunt work. But I'll have a go at it if you say
that's the way to go (even if it requires change to user code).

-j.

« Back to merge proposal