Code review comment for lp:~jobh/dolfin/fast-array

Revision history for this message
Joachim Haga (jobh) wrote :

On 24 February 2012 13:34, Garth Wells <email address hidden> wrote:

> Where in the code were the most Arrays being created?
>

I wrote:

> In GenericFunction::evaluate, via the chain
>
> Assembler::assemble_cells
> UFC::update
> Expression::restrict
>

... and indeed it's the rhs that involves an expression that's faster:
f = Expression("...")
L = f*v*dx
b = assemble(L)

goes from 8.0s on 64x64x64 to 2.7s. This accounts for most (all?) of the
35% speed-up for A and b combined.

-j.

« Back to merge proposal