Merge lp:~joao-gama/partner-contact-management/partner_auto_salesman into lp:~partner-contact-core-editors/partner-contact-management/7.0

[Joao Alfredo Gama Batista]

This is a teeny-tiny module that sets the default value for the salesman field with the current user id.

[Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)]

res.partner is provided by base module, not crm.

Please fix dependency.

review: Needs Fixing

[Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)]

No need for the class instanciation and the class should inherit from orm.Model

review: Needs Fixing

[Joao Alfredo Gama Batista (joao-gama)]

I did it like this to make the module compatible with older OE versions. I will fix it for this branch and propose another merge for the 6.1 branch.

[lp:~joao-gama/partner-contact-management/partner_auto_salesman]

19. By Joao Alfredo Gama Batista on 2013-03-06

[FIX] Use orm.Model instead of osv.osv

[Maxime Chambreuil (http://www.savoirfairelinux.com) (max3903)]

review: Approve (lgtm. no test.)

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

> I did it like this to make the module compatible with older OE versions. I
> will fix it for this branch and propose another merge for the 6.1 branch.

orm.Model is usable since 6.1, and the class instanciation is useless since 6.1 as well.
This code is 6.1 compatible.

review: Approve (code review, no test)

[Joao Alfredo Gama Batista (joao-gama)]

Let me rephrase myself. What I mean is that I tried to follow 6.x coding standards. I myself think that orm.Model is much clearer than osv.osv and the class instantiation at the end of each declaration is simply weird. ;)

[Guewen Baconnier @ Camptocamp (gbaconnier-c2c)]

> Let me rephrase myself. What I mean is that I tried to follow 6.x coding
> standards. I myself think that orm.Model is much clearer than osv.osv and the
> class instantiation at the end of each declaration is simply weird. ;)

Alright so we agree on that :-)

=== added directory 'partner_auto_salesman'
=== added file 'partner_auto_salesman/__init__.py'
--- partner_auto_salesman/__init__.py	1970-01-01 00:00:00 +0000
+++ partner_auto_salesman/__init__.py	2013-03-06 16:17:22 +0000
@@ -0,0 +1,22 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2013 Savoir-faire Linux (<http://www.savoirfairelinux.com>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+import res_partner
 
=== added file 'partner_auto_salesman/__openerp__.py'
--- partner_auto_salesman/__openerp__.py	1970-01-01 00:00:00 +0000
+++ partner_auto_salesman/__openerp__.py	2013-03-06 16:17:22 +0000
@@ -0,0 +1,35 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2013 Savoir-faire Linux (<http://www.savoirfairelinux.com>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+{
+    'name': 'Partner auto salesman',
+    'version': '1.0',
+    'category': 'Customer Relationship Management',
+    'complexity': "easy",
+    'description': """Fill the salesman field with the current user id""",
+    'author': 'Savoir-faire Linux',
+    'website': 'http://www.savoirfairelinux.com',
+    'license': 'AGPL-3',
+    'depends': ['base'],
+    'installable': True,
+    'auto_install': False,
+}
+# vim:expandtab:smartindent:tabstop=4:softtabstop=4:shiftwidth=4:
 
=== added file 'partner_auto_salesman/res_partner.py'
--- partner_auto_salesman/res_partner.py	1970-01-01 00:00:00 +0000
+++ partner_auto_salesman/res_partner.py	2013-03-06 16:17:22 +0000
@@ -0,0 +1,27 @@
+# -*- coding: utf-8 -*-
+##############################################################################
+#
+#    OpenERP, Open Source Management Solution
+#    Copyright (C) 2013 Savoir-faire Linux (<http://www.savoirfairelinux.com>).
+#
+#    This program is free software: you can redistribute it and/or modify
+#    it under the terms of the GNU Affero General Public License as
+#    published by the Free Software Foundation, either version 3 of the
+#    License, or (at your option) any later version.
+#
+#    This program is distributed in the hope that it will be useful,
+#    but WITHOUT ANY WARRANTY; without even the implied warranty of
+#    MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
+#    GNU Affero General Public License for more details.
+#
+#    You should have received a copy of the GNU Affero General Public License
+#    along with this program.  If not, see <http://www.gnu.org/licenses/>.
+#
+##############################################################################
+
+from openerp.osv import orm
+
+
+class res_partner(orm.Model):
+    _inherit = 'res.partner'
+    _defaults = {'user_id': lambda self, cr, uid, context: uid}