Code review comment for lp:~jml/udd/symbol-import

Revision history for this message
Jonathan Lange (jml) wrote :

On Thu, Oct 6, 2011 at 3:51 PM, Vincent Ladeuil <email address hidden> wrote:
>> add_failed_jobs is duplicating add_jobs_for_interrupted. If my new one
>> is missing functionality, then so is the existing one.
>
> No, retry indeed works for a single package, but it takes care about keeping track of previous failures which is the part that is missing. add_jobs_for_interrupted is catching up for... interrupted jobs which did not fail but needs to be spawn again.

They are recorded as failures using a sentinel. I fail to see why they
are different, or, to be honest, what would be required to make retry
usable for my needs.

jml

« Back to merge proposal