Code review comment for lp:~jml/udd/symbol-import

Revision history for this message
James Westby (james-w) wrote :

38 # XXX: This used to do "Published" for Ubuntu and "Pending" for
39 # Debian (which was really Ubuntu). Now we do both.

Hi,

I think we can just do Published now:

  https://bugs.launchpad.net/udd/+bug/865483

but if you don't want to make the two changes at once then that's ok.

49 # XXX: Don't know why there's a special check here for
50 # main packages in the current series. Used to be for
51 # Ubuntu only, now we check for all distros.

That's so that we record "important" packages in the db, so
we can start with those. Changing to all distros is fine.

That change looks good though. I'll let vila respond on the
comments that he made.

Thanks,

James

« Back to merge proposal