testtools

Code review comment for lp:~jml/testtools/better-twisted-debugging

  1. better-twisted-debugging
  2. Merge into trunk
Revision history for this message
Robert Collins (lifeless) wrote :

Strictly speaking, this:

+ finally:
+ self._reactor.stop = stop
+ self._restore_signals()

needs two finally clauses.

Otherwise its grand.

« Back to merge proposal