Code review comment for lp:~jml/testresources/tests-meaning-cleanup

On Fri, Aug 22, 2008 at 10:45 AM, Robert Collins
<email address hidden> wrote:
> On Thu, 2008-08-21 at 08:33 +0000, Jonathan Lange wrote:
>
>> > LICENSE | 19
>> >
>> > Move the copyright statements from all over the code into a top-level
>> > LICENSE
>> > file. Almost every file was affected by the move, so I won't mention it
>> > in
>> > their summaries.
>> >
>> > The license is still GPL v2 or better. Copyright is Robert Collins
>> > 2005-2008,
>> > except for priodict and dijkstra. I've filled in information about those
>> > last
>> > two as best as I can without Internet.
>> >
>> > ***** Please don't do this, best practice for the GPL is the
>> > header-per-file as I had, and as bzr (for example) does. The LICENCE
>> > file also fails to reference COPYING which is the actual copyright
>> > licence.
>> >
>>
>> OK. I'll revert this change, and if necessary bring the code inline
>> with http://www.gnu.org/licenses/gpl-howto.html
>
> It should have been inline before; please just put it back the way it
> was; I'd rather not have copyright changes that are dubious in the
> history at all in fact - you probably need to branch from before these
> changes and replay patches across.
>
> I'd be happy to review a separate branch discussing copyright changes
> though, but lets not conflate things.

I've pushed up a new version that no longer has the license changes
and makes the changes I agreed to above.

I'm looking forward to hearing your reply.

jml