Code review comment for lp:~jml/pkgme/reason-for-want

Revision history for this message
James Westby (james-w) wrote :

Hi,

291 + def test_want_script_with_missing_score(self):

should be ..._missing_reason I think?

Aside from that they only change I might make would be to extract a
method for running a python script with a given want response as
that is repeated in a few tests. I'm happy for it to land without
that change though.

Thanks,

James

review: Approve

« Back to merge proposal