Code review comment for lp:~jml/piston-mini-client/split-request-base-1041825

Revision history for this message
Jonathan Lange (jml) wrote :

On 2012-09-14::

16:48:19 <achuni> jml: I thought PistonAPI was going to use PistonRequester as a client in the end?
16:48:33 <achuni> (or did we agree to go the other way around in the end?)
16:48:59 <jml> achuni: you mean, use composition instead of inheritance?
16:49:04 <achuni> yep
16:49:51 <jml> achuni: I'd be very happy to do that. It'll mean potentially breaking backwards compat w/ existing PistonAPI users
16:50:21 <jml> achuni: or alternatively wrapping every existing method (e.g. _prepare_headers, _get_proxy_info, ...)
16:50:25 <achuni> jml: even if you leave the current _get / _post / ... methods there?
16:50:35 <achuni> ah, right
16:50:36 <achuni> hm
16:50:39 <jml> achuni: your call.
16:51:38 <achuni> jml: yep, we'd need to wrap all methods, I think... I'd say the wrappers can be deprecated immediately
16:52:23 <jml> achuni: want warnings for the deprecations, or are docstrings enough?
16:52:52 <achuni> jml: like PistonSerializable._as_serializable... I'm not sure that's the recommended way, but it's what was done last time
16:53:11 <jml> achuni: cool. I'll do that then.

I've now done this. I haven't cleared up the deprecation warnings in the tests.

« Back to merge proposal