Code review comment for lp:~jml/launchpadlib/ssl-creds

Revision history for this message
Benji York (benji) wrote :

Looks good.

It's too bad that the environment variable isn't discoverable. Maybe we could annotate SSH certificate errors with a message about how to disable validation. Or we could just whitelist the development sites with known-bad certs and the user won't see the errors to start with.

review: Approve (code)

« Back to merge proposal