Code review comment for lp:~jml/launchpadlib/fake-launchpad

Revision history for this message
Jeroen T. Vermeulen (jtv) wrote :

Thanks for being patient with my nitpicking. I do agree that this should go in quickly, with localized fixes only.

One thing however (hence the alarmist Needs Fixing vote): don't strip off the “-full” suffix using rstrip! That would strip off, say, “-flufl” as well (not nice to Barry) and turn “wonderful-lulu” into a mere “wonder.”

review: Needs Fixing

« Back to merge proposal