Hi Jono,
Disappointingly (or not, depending on your point of view) I've found nothing whatever to complain about in your tests. These need changing though:
> === added file 'src/launchpadlib/testing/launchpad.py' > --- src/launchpadlib/testing/launchpad.py 1970-01-01 00:00:00 +0000 > +++ src/launchpadlib/testing/launchpad.py 2011-09-14 15:20:28 +0000 > @@ -0,0 +1,531 @@ > +# Copyright 2008 Canonical Ltd. > +
This needs 2011 appending to it.
> === added file 'src/launchpadlib/testing/tests/__init__.py' > === added file 'src/launchpadlib/testing/tests/test_launchpad.py' > --- src/launchpadlib/testing/tests/test_launchpad.py 1970-01-01 00:00:00 +0000 > +++ src/launchpadlib/testing/tests/test_launchpad.py 2011-09-13 15:56:51 +0000 > @@ -0,0 +1,393 @@ > +# Copyright 2008 Canonical Ltd. > +
As does this.
r=me on the tests. I'll let Jeroen be the one to respond to your changes w.r.t his comments.
« Back to merge proposal
Hi Jono,
Disappointingly (or not, depending on your point of view) I've found nothing whatever to complain about in your tests. These need changing though:
> === added file 'src/launchpadl ib/testing/ launchpad. py' b/testing/ launchpad. py 1970-01-01 00:00:00 +0000 b/testing/ launchpad. py 2011-09-14 15:20:28 +0000
> --- src/launchpadli
> +++ src/launchpadli
> @@ -0,0 +1,531 @@
> +# Copyright 2008 Canonical Ltd.
> +
This needs 2011 appending to it.
> === added file 'src/launchpadl ib/testing/ tests/_ _init__ .py' ib/testing/ tests/test_ launchpad. py' b/testing/ tests/test_ launchpad. py 1970-01-01 00:00:00 +0000 b/testing/ tests/test_ launchpad. py 2011-09-13 15:56:51 +0000
> === added file 'src/launchpadl
> --- src/launchpadli
> +++ src/launchpadli
> @@ -0,0 +1,393 @@
> +# Copyright 2008 Canonical Ltd.
> +
As does this.
r=me on the tests. I'll let Jeroen be the one to respond to your changes w.r.t his comments.