Merge lp:~jml/launchpad/failing-tests-bug-711209 into lp:launchpad
Status: | Merged | ||||
---|---|---|---|---|---|
Approved by: | Curtis Hovey | ||||
Approved revision: | no longer in the source branch. | ||||
Merged at revision: | 12294 | ||||
Proposed branch: | lp:~jml/launchpad/failing-tests-bug-711209 | ||||
Merge into: | lp:launchpad | ||||
Diff against target: |
81 lines (+15/-11) 2 files modified
lib/canonical/testing/layers.py (+15/-4) lib/lp/testing/__init__.py (+0/-7) |
||||
To merge this branch: | bzr merge lp:~jml/launchpad/failing-tests-bug-711209 | ||||
Related bugs: |
|
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Curtis Hovey (community) | code | Approve | |
Review via email: mp+48184@code.launchpad.net |
Commit message
[r=sinzui]
Description of the change
This branch address bug 711209. Some Twisted tests in our suite were not failing when they ought to have been failing. This was because of a band-aid to solve a very similar problem, that turned out to be self-defeating once we were running tests without the underlying wound. i.e. the bandaid helps Trial tests, but not testtools Twisted tests.
The branch "solves" this problem by moving the bandaid into the TwistedLayer, which is only used for Trial tests. It has the pleasant side-effect of removing an import side-effect.
I verified that the fix works by adding a failing test to test_builder.py and watching it fail.
Note that fixing this bug might expose other tests that have been failing silently. Best thing to do is try to land this then watch the failures that come back from the server.
Thank you for providing this. I learn something about zope's frame introspection too.