Code review comment for lp:~jml/launchpad/drop-special-commercial-permissions

Revision history for this message
James Westby (james-w) wrote :

Hi,

This looks good to me from a code point of view.

Agree about the need for integration testing.

I think that we may also want to audit the current PPAs to make sure that
s-c-a won't lose permissions that it needs to complete sales of something
available in software-center. I'm not exactly sure how we would determine
that though.

Thanks,

James

review: Approve

« Back to merge proposal