Code review comment for lp:~jml/gtg/test-framework
Revision history for this message
| Jonathan Lange (jml) wrote | # |
© 2004
Canonical Ltd.
•
Terms of use
•
Data privacy
•
Contact Launchpad Support
•
Blog
•
Careers
•
System status
•
bbfa235
(Get the code!)
On Wed, Jul 15, 2009 at 11:06 PM, Lionel Dricot<email address hidden> wrote:
>
>> However, the broader idea is that 'make lint' *should* fail if there's
>> lint. We can change this if you'd like.
>
> I'm not sure I really understand this sentence. I thought that make lint
> would produce a number of errors that should be fixed.
>
That's what it does. However, like any script or any make process, it
can succeed or fail. In make, if a step fails, it says so. The "Error
2" thing you see is make bubbling up the error code of pyflakes.
So, one problem is that old versions of pyflakes think that
dbuswrapper is buggy.
The other problem (which is only a problem of expectations) is that
'make lint' says "Error" and doesn't run the PEP 8 checker if there
are any errors found.
jml