Code review comment for lp:~jml/gtg/test-framework

On Wed, Jul 15, 2009 at 5:27 PM, Lionel Dricot<email address hidden> wrote:
>> On Tue, Jul 14, 2009 at 11:19 PM, Lionel Dricot<email address hidden> wrote:
>>> I merged your branch because everything seems at least not worst than
>>> before. Make lint is not working for me but we will solve that.
>>>
>>
>> Not working for you? What's the behaviour you're seeing?
>
> 9:26 ploum@nout ~/gtg% make lint
> pyflakes GTG
> GTG/core/dbuswrapper.py:2: redefinition of unused 'dbus' from line 1
> GTG/core/dbuswrapper.py:3: redefinition of unused 'dbus' from line 2
> make: *** [pyflakes] Erreur 2
> zsh: exit 2     make lint
>

That bug has been fixed in Pyflakes, but it hasn't been released:
- http://divmod.org/trac/ticket/1826
- http://divmod.org/trac/changeset/17490

I recommend running from trunk, which you can get from Launchpad @
lp:pyflakes. I'll poke the maintainer to do another release.

However, the broader idea is that 'make lint' *should* fail if there's
lint. We can change this if you'd like.

jml