GTG

Code review comment for lp:~jml/gtg/test-framework

Revision history for this message
Lionel Dricot (ploum-deactivatedaccount) wrote :

> On Tue, Jul 14, 2009 at 11:19 PM, Lionel Dricot<email address hidden> wrote:
>> I merged your branch because everything seems at least not worst than
>> before. Make lint is not working for me but we will solve that.
>>
>
> Not working for you? What's the behaviour you're seeing?

9:26 ploum@nout ~/gtg% make lint
pyflakes GTG
GTG/core/dbuswrapper.py:2: redefinition of unused 'dbus' from line 1
GTG/core/dbuswrapper.py:3: redefinition of unused 'dbus' from line 2
make: *** [pyflakes] Erreur 2
zsh: exit 2 make lint

>
>> Could you verify if everything in fine in trunk ? (I solved a couple of
>> conflicts manually).
>>
>
> Done. Everything's good.
>
>> Could you update the wiki then ?
>>
>
> Done.
>
>> It looks like a real nice work, as seen in the HACKING file :-)
>>
>
> Thanks for saying so :)
>
> jml
> --
> https://code.launchpad.net/~jml/gtg/test-framework/+merge/8743
> You are subscribed to branch lp:gtg.
>

« Back to merge proposal