Code review comment for lp:~jml/divmod.org/pyflakes-reporter

Revision history for this message
Jonathan Lange (jml) wrote :

1. duplicate & simplify _EverythingGetter, rather than import it
 Done.

2. change mod_reactor import to modReactor (or similar), and change both __import__'s to __future__.absolute_import
 Done (except I should have said "mod_reporter", not "mod_reactor")

3. attempt to make the reporter interface all text, documenting it as such
 Done, I think.

4. attempt to unify the multiple import methods
 Done, sort of. Combined ioError and problemDecodingSource into one unexpectedError method. Syntax errors have special needs re output, so have left as-is.

I think we're good to merge now.

« Back to merge proposal