This feedback has already been given over IRC, but for the record:
38 + full_path = self._root_client_path + final_stack[1:] 39 + final_stack = urlutils.relative_url( 40 + target_transport.base, full_path)
didn't make sense to me.
What would make sense to me would be s/full_path/client_path/, and changing the first arg of relative_url to _root_client_path.
+ self.reset_smart_call_log()
Omit self.reset_smart_call_log() calls if you aren't going to inspect the call log in the test.
Everything else seems ok, I think.
« Back to merge proposal
This feedback has already been given over IRC, but for the record:
38 + full_path = self._root_ client_ path + final_stack[1:] relative_ url( transport. base, full_path)
39 + final_stack = urlutils.
40 + target_
didn't make sense to me.
What would make sense to me would be s/full_ path/client_ path/, and changing the first arg of relative_url to _root_client_path.
+ self.reset_ smart_call_ log()
Omit self.reset_ smart_call_ log() calls if you aren't going to inspect the call log in the test.
Everything else seems ok, I think.