Code review comment for lp:~jml/bzr/default-stacking-bug-385132

Revision history for this message
Andrew Bennetts (spiv) wrote :

This feedback has already been given over IRC, but for the record:

38 + full_path = self._root_client_path + final_stack[1:]
39 + final_stack = urlutils.relative_url(
40 + target_transport.base, full_path)

didn't make sense to me.

What would make sense to me would be s/full_path/client_path/, and changing the first arg of relative_url to _root_client_path.

+ self.reset_smart_call_log()

Omit self.reset_smart_call_log() calls if you aren't going to inspect the call log in the test.

Everything else seems ok, I think.

review: Approve

« Back to merge proposal