Code review comment for lp:~jmiguelbenitez/pantheon-files/fix-1076504

Revision history for this message
Jeremy Wootten (jeremywootten) wrote :

Performs as specified and no conflicts found with current trunk.
There are some minor formatting problems: misalignments in diff lines 49, 53 57.

My only reservation is that the ratio of item-width to icon-size is arbitrarily set at 2 and hard-coded. I tried altering this and personally found a slightly more compact layout more aesthetically pleasing, using the "Golden Ratio" (162/100 approx). Wouldn't it be better to make this a setting or get the input of the design team as to the optimum ratio?

Also, the entire switch statement could be replaced by a single line using a fixed ratio of wrap-width to item-width of 95/100 with no discernible difference.

review: Needs Fixing

« Back to merge proposal