Merge ~jmelvin/cloud-init:my-topic-branch2 into cloud-init:master

Proposed by Jeremy Melvin
Status: Merged
Merged at revision: 482b2746b5919233afec55776d5fc996cdc2f38e
Proposed branch: ~jmelvin/cloud-init:my-topic-branch2
Merge into: cloud-init:master
Diff against target: 13 lines (+1/-1)
1 file modified
cloudinit/config/cc_chef.py (+1/-1)
Reviewer Review Type Date Requested Status
Server Team CI bot continuous-integration Approve
cloud-init Commiters Pending
Review via email: mp+319612@code.launchpad.net

Commit message

Fix chef config module in omnibus install.

  Omnibus installation of chef was broken.
  LP: #1583837

To post a comment you must log in.
Revision history for this message
Jeremy Melvin (jmelvin) wrote :

Fix chef config module in omnibus install.

  Omnibus installation of chef was broken.
  LP: #1583837

Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Needs Fixing (continuous-integration)
~jmelvin/cloud-init:my-topic-branch2 updated
891554b... by Jeremy Melvin <email address hidden>

Fix chef config module in omnibus install.

  Omnibus installation of chef was broken.
  LP: #1583837

38aee16... by Jeremy Melvin <email address hidden>

Fix chef config module in omnibus install.

  Omnibus installation of chef was broken.
  LP: #1583837

Revision history for this message
Server Team CI bot (server-team-bot) wrote :
review: Approve (continuous-integration)

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
1diff --git a/cloudinit/config/cc_chef.py b/cloudinit/config/cc_chef.py
2index f6564e5..2be2532 100644
3--- a/cloudinit/config/cc_chef.py
4+++ b/cloudinit/config/cc_chef.py
5@@ -302,7 +302,7 @@ def install_chef(cloud, chef_cfg, log):
6 retries = max(0, util.get_cfg_option_int(chef_cfg,
7 "omnibus_url_retries",
8 default=OMNIBUS_URL_RETRIES))
9- content = url_helper.readurl(url=url, retries=retries)
10+ content = url_helper.readurl(url=url, retries=retries).contents
11 with util.tempdir() as tmpd:
12 # Use tmpdir over tmpfile to avoid 'text file busy' on execute
13 tmpf = "%s/chef-omnibus-install" % tmpd

Subscribers

People subscribed via source and target branches