Ubuntu
gvfs package

Code review comment for lp:~jm-leddy/ubuntu/oneiric/gvfs/fix-899858

  1. Oneiric (11.10)
  2. fix-899858
  3. Merge into oneiric
Revision history for this message
Mathieu Trudel-Lapierre (cyphermox) wrote :

AFAICS, this looks good. The only thing I noticed wrong was that for an upload for SRU to Oneiric, the changelog entry should target oneiric-proposed, not oneiric-updates. I made the change myself while preparing the merge for an upload.

There was also some confusion with .pc/gvfs/daemon/Makefile.am, which shouldn't have been removed in the branch.

Needless to say, this will require careful testing on oneiric to verify that there are no regressions introduced with that change.

review: Approve

« Back to merge proposal