Merge lp:~jkeyes0/reminders-app/reminders-tab into lp:reminders-app

[Jordan Keyes]

Added a ListView with sample ListElements for the Reminders tab.

[Nekhelesh Ramananthan (nik90)]

Hey Jordan, that looks much better. Some small things which need fixing,

8 - "maintainer": "Ubuntu Reminders app developers <email address hidden>",
9 + "maintainer": "",

Can you revert this alone. It would be best for the reminders app dev to be the maintainer in the manifest.json file.

44 === added file 'ui/RemindersModel.qml'

Would you mind moving this file to the components folder since the UI folder is primarily for pages, tabs and other UI elements.

Otherwise the code looks good.

review: Needs Fixing

[lp:~jkeyes0/reminders-app/reminders-tab]

6. By Jordan Keyes on 2013-11-21

Reverted change to manifest.json, moved RemindersModel to components directory

[Jordan Keyes (jkeyes0)]

Sure, no problem! I had the RemindersModel in the ui directory after seeing a comment dpm made about possibly removing the components directory, but I agree that it makes more sense to have the individual pieces in the components directory, leaving the ui directory for pages/tabs/etc.

[lp:~jkeyes0/reminders-app/reminders-tab]

7. By Jordan Keyes on 2013-11-21

Added reference to components for RemindersModel

Unmerged revisions

=== added file 'components/RemindersModel.qml'
--- components/RemindersModel.qml	1970-01-01 00:00:00 +0000
+++ components/RemindersModel.qml	2013-11-21 13:47:09 +0000
@@ -0,0 +1,17 @@
+import QtQuick 2.0
+
+ListModel {
+    ListElement {
+        name: "Buy Milk"
+        date: "2013-11-18"
+    }
+    ListElement {
+        name: "Pick Up Kids"
+        date: "2013-11-19"
+    }
+    ListElement {
+        name: "Take Over World"
+        date: "2013-11-20"
+    }
+
+}
 
=== modified file 'manifest.json'
--- manifest.json	2013-11-20 21:56:49 +0000
+++ manifest.json	2013-11-21 13:47:09 +0000
@@ -11,4 +11,4 @@
     "name": "com.ubuntu.reminders-app",
     "title": "reminders-app",
     "version": "0.1"
-}
+}
 \ No newline at end of file
 
=== modified file 'ui/Reminders.qml'
--- ui/Reminders.qml	2013-11-20 21:00:20 +0000
+++ ui/Reminders.qml	2013-11-21 13:47:09 +0000
@@ -1,5 +1,6 @@
 import QtQuick 2.0
 import Ubuntu.Components 0.1
+import Ubuntu.Components.ListItems 0.1
 
 Page {
     id: remindersPage
@@ -9,4 +10,18 @@
         anchors.centerIn: parent
         text: i18n.tr("This page is still in development")
     }
+
+    ListView {
+
+        width: parent.width; height: parent.height
+
+        delegate: Subtitled {
+            text: '<b>Name:</b> ' + model.name
+            subText: '<b>Date:</b> ' + model.date
+        }
+
+        model: RemindersModel {}
+
+    }
+
 }