Merge lp:~jkeyes0/reminders-app/reminders-tab into lp:reminders-app
Proposed by
Jordan Keyes
Status: | Superseded |
---|---|
Proposed branch: | lp:~jkeyes0/reminders-app/reminders-tab |
Merge into: | lp:reminders-app |
Diff against target: |
62 lines (+33/-1) 3 files modified
components/RemindersModel.qml (+17/-0) manifest.json (+1/-1) ui/Reminders.qml (+15/-0) |
To merge this branch: | bzr merge lp:~jkeyes0/reminders-app/reminders-tab |
Related bugs: |
Reviewer | Review Type | Date Requested | Status |
---|---|---|---|
Nekhelesh Ramananthan (community) | Needs Fixing | ||
Review via email: mp+196037@code.launchpad.net |
This proposal has been superseded by a proposal from 2013-11-21.
Description of the change
Added a ListView with sample ListElements for the Reminders tab.
To post a comment you must log in.
Hey Jordan, that looks much better. Some small things which need fixing,
8 - "maintainer": "Ubuntu Reminders app developers <email address hidden>",
9 + "maintainer": "",
Can you revert this alone. It would be best for the reminders app dev to be the maintainer in the manifest.json file.
44 === added file 'ui/RemindersMo del.qml'
Would you mind moving this file to the components folder since the UI folder is primarily for pages, tabs and other UI elements.
Otherwise the code looks good.