Merge lp:~jkakar/txsolr/makefile-787491 into lp:txsolr

Proposed by Jamu Kakar
Status: Merged
Merged at revision: 57
Proposed branch: lp:~jkakar/txsolr/makefile-787491
Merge into: lp:txsolr
Diff against target: 46 lines (+34/-0)
2 files modified
.bzrignore (+2/-0)
Makefile (+32/-0)
To merge this branch: bzr merge lp:~jkakar/txsolr/makefile-787491
Reviewer Review Type Date Requested Status
Terry Jones (community) Approve
Manuel Cerón Approve
Review via email: mp+62105@code.launchpad.net

Description of the change

This branch introduces the following changes:

- A Makefile with some handy targets has been added to the project.

- Files generated by setup.py have been added to Bazaar's ignore list.

To post a comment you must log in.
Revision history for this message
Manuel Cerón (ceronman) wrote :

+1. Nice improvement.

review: Approve
Revision history for this message
Jamu Kakar (jkakar) wrote :

Should we just land this? Not sure it really needs two reviews.

Revision history for this message
Terry Jones (terrycojones) wrote :

I would add --repeat to the pep8 call, to see all errors.

I also find pep8 more reliable if I only give it one file
at a time. So I tend to use

find . -name '*.py' | xargs -n 1 pep8 --repeat

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file '.bzrignore'
--- .bzrignore 2010-09-10 22:20:00 +0000
+++ .bzrignore 2011-05-24 11:18:42 +0000
@@ -2,3 +2,5 @@
2.project2.project
3.settings3.settings
4_trial_temp4_trial_temp
5MANIFEST
6dist
57
=== added file 'Makefile'
--- Makefile 1970-01-01 00:00:00 +0000
+++ Makefile 2011-05-24 11:18:42 +0000
@@ -0,0 +1,32 @@
1clean:
2 find . -name \*pyc -exec rm {} \;
3 rm -rf doc
4 rm -rf _trial_temp
5
6check:
7 trial txsolr
8
9info:
10 @bzr info
11 @echo
12 @echo "Revision:"
13 @bzr revno
14 @echo
15 @echo "Lines of application code:"
16 @find txsolr -name \*py | grep -v test_ | xargs cat | wc -l
17 @echo
18 @echo "Lines of test code:"
19 @find txsolr -name \*py | grep test_ | xargs cat | wc -l
20
21lint:
22 pep8 $(shell find . -name \*py)
23 pyflakes $(shell find . -name \*py)
24
25api:
26 pydoctor --project-name txSolr \
27 --make-html \
28 --html-output doc \
29 --add-package txsolr
30
31release:
32 python setup.py sdist

Subscribers

People subscribed via source and target branches

to all changes: