txAWS

Code review comment for lp:~jkakar/txaws/silence-deprecation-warnings

  1. silence-deprecation-warnings
  2. Merge into trunk
Revision history for this message
Duncan McGreggor (oubiwann) wrote :

Note sure if you want to address Python 2.6 deprecation warnings at the same time:

    test_submit_400 ... [OK]
/mnt/oubiwann/lab/txAWS/branches/silence-deprecation-warnings/txaws/client/base.py:40: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6
    test_submit_500 ... [OK]
/mnt/oubiwann/lab/txAWS/branches/silence-deprecation-warnings/txaws/client/base.py:40: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6
    test_submit_non_EC2_400 ... [OK]
/mnt/oubiwann/lab/txAWS/branches/silence-deprecation-warnings/txaws/client/base.py:40: DeprecationWarning: BaseException.message has been deprecated as of Python 2.6

Changes look good; all tests pass on Python 2.6 and Python 2.7; +1 for merge, regardless what you want to do about the 2.6 exceptions.

review: Approve

« Back to merge proposal