Code review comment for lp:~jkakar/launchpadlib/fake-launchpad

Revision history for this message
Gavin Panella (allenap) wrote :

> It's been awhile since I looked at this, so not surprised there's some
> bitrot... I guess one issue is that there's an old WADL here, whereas
> the WADL should probably be pulled dynamically. Does anyone know what
> we need to do to get this landed...? It's not clear to me anymore.

I think the signatures of the methods that are faked need to be
updated where they're out of date. It would be nice to have a test to
keep them in sync, but I don't think that should block landing.

Perhaps the WADL could be updated too. Not being able to get it
dynamically should not block landing either, IMO.

It might be worth issuing a warning when importing the new modules,
just to tell people that it's an alpha feature for now.

« Back to merge proposal