Code review comment for ~jk0ne/charm-k8s-discourse/+git/charm-k8s-discourse:master

Revision history for this message
Tom Haddon (mthaddon) wrote :

Some minor comments inline.

Also, per the comment above please add docstrings to all functions/methods in src/charm.py and in the unit tests.

Thanks for the test data changes. Any objection to trying to find more descriptive names for the test data files than 'config_valid_{1,2,3}.yaml', for instance? Possibly something like 'config_valid_basic.yaml', 'config_valid_with_tls.yaml', etc.? I think this makes it a lot easier to understand for someone new to the code what's being tested.

« Back to merge proposal