> I didn't bother with HyperV since that layer is extremely bare at the moment.
Not a deal-breaker, but might be a good idea to add to HyperV anyway so it doesn't fall any further behind. Whomever ends up owning HyperV will benefit greatly from the stubs, and they cost next to nothing to add.
> Another possibility is the big XenAPI refactor that we've talked about
Yeah, I'm pretty much in agreement with you here. As much as I hate to see methods which are near-duplicates, I don't see an easy way around without some refactoring.
`_poll_tasks` in xenapi_conn.py is particularly nefarious, considering it takes an instance_id, optionally.
So, with both those items cleared up, I think this patch is good-to-go. Great job, Josh!
> I didn't bother with HyperV since that layer is extremely bare at the moment.
Not a deal-breaker, but might be a good idea to add to HyperV anyway so it doesn't fall any further behind. Whomever ends up owning HyperV will benefit greatly from the stubs, and they cost next to nothing to add.
> Another possibility is the big XenAPI refactor that we've talked about
Yeah, I'm pretty much in agreement with you here. As much as I hate to see methods which are near-duplicates, I don't see an easy way around without some refactoring.
`_poll_tasks` in xenapi_conn.py is particularly nefarious, considering it takes an instance_id, optionally.
So, with both those items cleared up, I think this patch is good-to-go. Great job, Josh!