Merge lp:~jk0/glance/pep8 into lp:~hudson-openstack/glance/trunk

Proposed by Josh Kearney
Status: Merged
Approved by: Jay Pipes
Approved revision: 53
Merged at revision: 54
Proposed branch: lp:~jk0/glance/pep8
Merge into: lp:~hudson-openstack/glance/trunk
Diff against target: 94 lines (+11/-11)
4 files modified
doc/source/conf.py (+2/-2)
tests/stubs.py (+3/-2)
tests/unit/test_clients.py (+3/-3)
tests/unit/test_stores.py (+3/-4)
To merge this branch: bzr merge lp:~jk0/glance/pep8
Reviewer Review Type Date Requested Status
Jay Pipes (community) Approve
Rick Harris (community) Approve
Review via email: mp+47556@code.launchpad.net

Commit message

PEP8 cleanup.

To post a comment you must log in.
Revision history for this message
Rick Harris (rconradharris) wrote :

lgtm

review: Approve
Revision history for this message
Jay Pipes (jaypipes) wrote :

Cool.

review: Approve

Preview Diff

[H/L] Next/Prev Comment, [J/K] Next/Prev File, [N/P] Next/Prev Hunk
=== modified file 'doc/source/conf.py'
--- doc/source/conf.py 2011-01-26 16:01:48 +0000
+++ doc/source/conf.py 2011-01-26 16:54:54 +0000
@@ -118,9 +118,9 @@
118# A list of ignored prefixes for module index sorting.118# A list of ignored prefixes for module index sorting.
119modindex_common_prefix = ['glance.']119modindex_common_prefix = ['glance.']
120120
121# -- Options for man page output -----------------------------------------------121# -- Options for man page output ----------------------------------------------
122122
123# Grouping the document tree for man pages. 123# Grouping the document tree for man pages.
124# List of tuples 'sourcefile', 'target', u'title', u'Authors name', 'manual'124# List of tuples 'sourcefile', 'target', u'title', u'Authors name', 'manual'
125125
126man_pages = [126man_pages = [
127127
=== modified file 'tests/stubs.py'
--- tests/stubs.py 2011-01-20 20:27:41 +0000
+++ tests/stubs.py 2011-01-26 16:54:54 +0000
@@ -117,6 +117,7 @@
117117
118 class FakeSwiftAuth(object):118 class FakeSwiftAuth(object):
119 pass119 pass
120
120 class FakeS3Connection(object):121 class FakeS3Connection(object):
121 pass122 pass
122123
@@ -134,8 +135,8 @@
134135
135 def chunk_it():136 def chunk_it():
136 for i in xrange(0, len(cls.DATA), cls.CHUNK_SIZE):137 for i in xrange(0, len(cls.DATA), cls.CHUNK_SIZE):
137 yield cls.DATA[i:i+cls.CHUNK_SIZE]138 yield cls.DATA[i:i + cls.CHUNK_SIZE]
138 139
139 return chunk_it()140 return chunk_it()
140141
141 fake_swift_backend = FakeS3Backend()142 fake_swift_backend = FakeS3Backend()
142143
=== modified file 'tests/unit/test_clients.py'
--- tests/unit/test_clients.py 2011-01-18 17:58:23 +0000
+++ tests/unit/test_clients.py 2011-01-26 16:54:54 +0000
@@ -388,7 +388,7 @@
388 'is_public': True,388 'is_public': True,
389 'type': 'kernel'389 'type': 'kernel'
390 }390 }
391 391
392 image_meta = self.client.add_image(fixture)392 image_meta = self.client.add_image(fixture)
393 self.assertEquals('queued', image_meta['status'])393 self.assertEquals('queued', image_meta['status'])
394 self.assertEquals(0, image_meta['size'])394 self.assertEquals(0, image_meta['size'])
@@ -401,7 +401,7 @@
401 'size': 19,401 'size': 19,
402 'location': "file:///tmp/glance-tests/2",402 'location': "file:///tmp/glance-tests/2",
403 }403 }
404 404
405 new_image = self.client.add_image(fixture)405 new_image = self.client.add_image(fixture)
406 new_image_id = new_image['id']406 new_image_id = new_image['id']
407407
@@ -434,7 +434,7 @@
434 'location': "file:///tmp/glance-tests/2",434 'location': "file:///tmp/glance-tests/2",
435 'properties': {'distro': 'Ubuntu 10.04 LTS'}435 'properties': {'distro': 'Ubuntu 10.04 LTS'}
436 }436 }
437 437
438 new_image = self.client.add_image(fixture)438 new_image = self.client.add_image(fixture)
439 new_image_id = new_image['id']439 new_image_id = new_image['id']
440440
441441
=== modified file 'tests/unit/test_stores.py'
--- tests/unit/test_stores.py 2011-01-14 19:32:52 +0000
+++ tests/unit/test_stores.py 2011-01-26 16:54:54 +0000
@@ -96,17 +96,16 @@
96 def test_get(self):96 def test_get(self):
97 s3_uri = "s3://user:password@localhost/bucket1/file.tar.gz"97 s3_uri = "s3://user:password@localhost/bucket1/file.tar.gz"
9898
99 expected_returns = ['I ', 'am', ' a', ' t', 'ea', 'po', 't,', ' s', 99 expected_returns = ['I ', 'am', ' a', ' t', 'ea', 'po', 't,', ' s',
100 'ho', 'rt', ' a', 'nd', ' s', 'to', 'ut', '\n']100 'ho', 'rt', ' a', 'nd', ' s', 'to', 'ut', '\n']
101 fetcher = get_from_backend(s3_uri, 101 fetcher = get_from_backend(s3_uri,
102 expected_size=8, 102 expected_size=8,
103 conn_class=S3Backend)103 conn_class=S3Backend)
104104
105 chunks = [c for c in fetcher]105 chunks = [c for c in fetcher]
106 self.assertEqual(chunks, expected_returns)106 self.assertEqual(chunks, expected_returns)
107107
108108
109
110class TestSwiftBackend(TestBackend):109class TestSwiftBackend(TestBackend):
111110
112 def setUp(self):111 def setUp(self):

Subscribers

People subscribed via source and target branches